yuqi1129 commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2650754851
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -740,43 +741,40 @@ public boolean dropCatalog(NameIdentifier ident, boolean
force)
() -> {
checkMetalake(metalakeIdent, store);
try {
- boolean catalogInUse = catalogInUse(store, ident);
+ boolean catalogInUse = getCatalogInUseValue(store, ident);
Review Comment:
This part is LGTM currently, and we will use another PR to resolve it.
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -893,6 +894,15 @@ private boolean getCatalogInUseValue(EntityStore store,
NameIdentifier catalogId
}
}
+ private boolean isManagedCatalog(CatalogWrapper catalogWrapper) {
+ try {
+ return
catalogWrapper.capabilities().managedStorage(Capability.Scope.CATALOG).supported();
+ } catch (Exception e) {
+ LOG.warn("Failed to get capabilities for catalog, assuming not managed",
e);
+ return false;
Review Comment:
When will we get an exception here? Is it better to throw it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
