diqiu50 commented on code in PR #9569:
URL: https://github.com/apache/gravitino/pull/9569#discussion_r2671015161
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -166,19 +173,14 @@ static class FileSystemCacheKey {
// authority are both null
@Nullable private final String scheme;
@Nullable private final String authority;
- private final Map<String, String> conf;
+ @Nullable private String locationName;
private final String currentUser;
- FileSystemCacheKey(String scheme, String authority, Map<String, String>
conf) {
+ FileSystemCacheKey(String scheme, String authority, String locationName) {
Review Comment:
I don’t think it needs to be this complicated.
For case 1, creating two HDFS objects is fine.
For case 2, why can’t we simply state that locationName is unique within the
catalog? In practice, it is unique in real usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
