yuqi1129 commented on code in PR #9569:
URL: https://github.com/apache/gravitino/pull/9569#discussion_r2671225646
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -166,19 +173,14 @@ static class FileSystemCacheKey {
// authority are both null
@Nullable private final String scheme;
@Nullable private final String authority;
- private final Map<String, String> conf;
+ @Nullable private String locationName;
private final String currentUser;
- FileSystemCacheKey(String scheme, String authority, Map<String, String>
conf) {
+ FileSystemCacheKey(String scheme, String authority, String locationName) {
Review Comment:
I'm also afraid that the configurations affect the filesystem instance.
Currently, properties did take effect on the fileset level.
Another point is that we can assume that the location name is unique within
a catalog.
##########
catalogs/hadoop-common/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##########
@@ -51,28 +44,14 @@ public class FileSystemUtils {
private FileSystemUtils() {}
- public static Map<String, FileSystemProvider> getFileSystemProviders(String
fileSystemProviders) {
+ public static Map<String, FileSystemProvider> getFileSystemProviders() {
Review Comment:
@mchades
Do you have any thoughts on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
