mchades commented on code in PR #9569:
URL: https://github.com/apache/gravitino/pull/9569#discussion_r2671162556
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -166,19 +173,14 @@ static class FileSystemCacheKey {
// authority are both null
@Nullable private final String scheme;
@Nullable private final String authority;
- private final Map<String, String> conf;
+ @Nullable private String locationName;
private final String currentUser;
- FileSystemCacheKey(String scheme, String authority, Map<String, String>
conf) {
+ FileSystemCacheKey(String scheme, String authority, String locationName) {
Review Comment:
> why can’t we simply state that locationName is unique within the catalog?
The `locationName` in each fileset is independent, and it is unreasonable to
restrict the fileset `locationName` at the catalog level. We did not have this
restriction from the beginning of our design
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
