FANNG1 commented on PR #9785: URL: https://github.com/apache/gravitino/pull/9785#issuecomment-3890753737
> > > > Do you want to change related document in this PR? > > > > > > > > > I have modified. https://github.com/apache/gravitino/pull/9785/changes#diff-d53b1f7fe17b81518ae45dda140fa9ae0264fba2627deb7c1240bd644e804709 > > > > > > Seems not enough, before this PR, the connector side, like Spark doesn't need to specify the AKSK as it's transformed by GravitinoSparkConnector automatically. > > > > > Do you want to change related document in this PR? > > > > > > > > > I have modified. https://github.com/apache/gravitino/pull/9785/changes#diff-d53b1f7fe17b81518ae45dda140fa9ae0264fba2627deb7c1240bd644e804709 > > > > > > Seems not enough, before this PR, the connector side, like Spark doesn't need to specify the AKSK as it's transformed by GravitinoSparkConnector automatically. > > This is a work round. Actually, I have added the config option to turn off the feature if required. We should use KMS to solve this issue. Only Spark has the work around, Trino and Flink don't have similar work around. The workaround seems tricky. I don't prefer adding these documents in our official document. This PR is a user-facing change that will cause the Spark connector to behave abnormally. There is nothing about whether this is a work round or not. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
