FANNG1 commented on PR #9785:
URL: https://github.com/apache/gravitino/pull/9785#issuecomment-3890775388
Here is a review comment from AI, what do you think? cc @yuqi1129
```
The patch introduces a lifecycle bug where catalog objects are used after
their isolated
classloader has been closed. This can break catalog listing in real
deployments depending
on provider class-loading behavior.
Review comment:
- [P1] Keep catalog classloader alive while reading property metadata —
/Users/fanng/
opensource/gravitino/core/src/main/java/org/apache/gravitino/catalog/
CatalogManager.java:1006-1009
getBaseCatalog returns a BaseCatalog after leaving the try
(IsolatedClassLoader ...)
block, so the classloader is closed before callers invoke
catalog.catalogPropertiesMetadata() in listCatalogsInfo. For providers
that lazily load
metadata classes/resources, this can trigger
ClassNotFoundException/NoClassDefFoundError
when listing catalogs with details, causing the API to fail at runtime.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
