roryqi commented on code in PR #9785:
URL: https://github.com/apache/gravitino/pull/9785#discussion_r2798817765
##########
bundles/gcp/src/main/java/org/apache/gravitino/gcs/credential/GCSTokenProvider.java:
##########
@@ -37,4 +40,9 @@ public String credentialType() {
public String getGeneratorClassName() {
return "org.apache.gravitino.gcs.credential.GCSTokenGenerator";
}
+
+ @Override
+ public Set<String> sensitivePropertyKeys() {
+ return
Sets.newHashSet(GCSCredentialConfig.GCS_CREDENTIAL_FILE_PATH.getKey());
Review Comment:
OK for me to remove this, too.
##########
docs/gravitino-server-config.md:
##########
@@ -264,6 +264,7 @@ Writer configuration begins with
`gravitino.audit.writer.${name}`, where `${name
Refer to [security](security/security.md) for HTTPS and authentication
configurations.
+
Review Comment:
Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
