sunyuhan1998 commented on code in PR #10895:
URL: https://github.com/apache/gravitino/pull/10895#discussion_r3216050891


##########
lance/lance-rest-server/src/test/java/org/apache/gravitino/lance/integration/test/LanceRESTServiceIT.java:
##########
@@ -960,6 +962,63 @@ void testDeclareTable() {
     Assertions.assertFalse(new File(anotherLocation).exists());
   }
 
+  @Test
+  void testDescribeTableWithCredentialVending() {
+    // Skip in deploy mode: the dummy credential provider is only available in 
test classpath
+    org.junit.Assume.assumeTrue(
+        "Credential vending IT only runs in embedded mode",
+        ITUtils.EMBEDDED_TEST_MODE.equals(testMode));
+
+    // Create a catalog with credential-providers configured to use the dummy 
provider
+    String credCatalogName = 
GravitinoITUtils.genRandomName("lance_cred_catalog");
+    Map<String, String> credCatalogProps =
+        new HashMap<>() {
+          {
+            put("credential-providers", 
LanceDummyCredentialProvider.CREDENTIAL_TYPE);
+          }
+        };

Review Comment:
   We'd prefer to keep the current style for consistency with other test 
methods in this file that use the same pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to