diqiu50 commented on code in PR #11073:
URL: https://github.com/apache/gravitino/pull/11073#discussion_r3286556133
##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueIcebergTableHelper.java:
##########
@@ -207,6 +234,71 @@ static void loadTable(Catalog icebergCatalog, String
dbName, String tableName, G
}
}
+ /**
+ * Converts an Iceberg type to the equivalent Gravitino type.
+ *
+ * <p>TIME and TIMESTAMP types are always returned with microsecond (6)
precision, matching
+ * Iceberg's internal representation.
+ */
+ // The parameter uses FQN because org.apache.iceberg.types.Type and
+ // org.apache.gravitino.rel.types.Type share the same simple name.
+ static Type fromIcebergType(org.apache.iceberg.types.Type icebergType) {
Review Comment:
We should avoid adding a dependency from the Glue catalog module to the
Iceberg catalog. Refactoring the Iceberg-specific logic into a shared module is
a larger effort and out of scope for this PR. I’ll add a TODO and handle it
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
