diqiu50 commented on code in PR #11073:
URL: https://github.com/apache/gravitino/pull/11073#discussion_r3287104837
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryIT.java:
##########
@@ -480,18 +490,9 @@ void executeSqlFileWithGenOutput(
}
firstLine = false;
- String sql = sqlMatcher.group(1);
+ String sql = resolveParameters(sqlMatcher.group(1));
String result = queryRunner.runQuery(sql).trim();
LOG.info("Execute sql:\n{}\nResult:\n{}", sql, result);
- if (isQueryFailed(result)) {
- throw new RuntimeException(
- "Failed to execute sql in the test set. "
- + simpleTesterName(path)
- + ":\n"
- + sql
- + "\nresult:\n"
- + result);
- }
outputStream.write(result.getBytes(StandardCharsets.UTF_8));
outputStream.write("\n".getBytes(StandardCharsets.UTF_8));
Review Comment:
No a problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
