yuqi1129 commented on code in PR #11073:
URL: https://github.com/apache/gravitino/pull/11073#discussion_r3297974251


##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueIcebergTableHelper.java:
##########
@@ -694,6 +789,15 @@ private static NullOrder toIcebergNullOrder(NullOrdering 
ordering) {
    *
    * <p>Iceberg does not expose transform parameters through a typed API, so 
string parsing is used.
    */
+  private static String requireColumnName(Schema schema, int sourceId) {

Review Comment:
   From the code, I could not get the meaning of `require` here, also, please 
update the method comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to