lasdf1234 commented on code in PR #11226:
URL: https://github.com/apache/gravitino/pull/11226#discussion_r3312080356


##########
plugins/idp-basic/src/test/java/org/apache/gravitino/idp/integration/test/IdpRESTApiIT.java:
##########
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.idp.integration.test;
+
+import static org.apache.gravitino.integration.test.util.BaseIT.setEnv;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import com.google.common.collect.ImmutableMap;
+import java.io.IOException;
+import java.net.URI;
+import java.net.http.HttpClient;
+import java.net.http.HttpRequest;
+import java.net.http.HttpResponse;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Arrays;
+import java.util.Base64;
+import java.util.Comparator;
+import java.util.List;
+import java.util.UUID;
+import java.util.stream.Stream;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.gravitino.Config;
+import org.apache.gravitino.Configs;
+import org.apache.gravitino.GravitinoEnv;
+import org.apache.gravitino.auth.AuthConstants;
+import org.apache.gravitino.auxiliary.AuxiliaryServiceManager;
+import org.apache.gravitino.config.ConfigConstants;
+import org.apache.gravitino.dto.responses.ErrorConstants;
+import org.apache.gravitino.idp.IdpUserGroupManager;
+import org.apache.gravitino.idp.dto.requests.AddGroupRequest;
+import org.apache.gravitino.idp.dto.requests.AddUserRequest;
+import org.apache.gravitino.idp.dto.requests.ChangePasswordRequest;
+import org.apache.gravitino.idp.dto.requests.GroupMembershipChangeRequest;
+import org.apache.gravitino.idp.dto.responses.IdpGroupResponse;
+import org.apache.gravitino.idp.dto.responses.IdpUserResponse;
+import org.apache.gravitino.integration.test.container.ContainerSuite;
+import org.apache.gravitino.integration.test.container.MySQLContainer;
+import org.apache.gravitino.integration.test.container.PostgreSQLContainer;
+import org.apache.gravitino.integration.test.util.TestDatabaseName;
+import org.apache.gravitino.json.JsonUtils;
+import org.apache.gravitino.rest.RESTUtils;
+import org.apache.gravitino.server.GravitinoServer;
+import org.apache.gravitino.server.ServerConfig;
+import org.apache.gravitino.server.web.JettyServerConfig;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+import org.mockito.Mockito;
+
+/**
+ * End-to-end tests for built-in IdP REST APIs on an embedded Gravitino server.
+ *
+ * <p>Runs the same REST scenario against H2, MySQL, and PostgreSQL relational 
backends.
+ */
+@Tag("gravitino-docker-test")
+public class IdpRestApiIT {
+
+  private static final String H2_BACKEND = "h2";
+  private static final String MYSQL_BACKEND = "mysql";
+  private static final String POSTGRESQL_BACKEND = "postgresql";
+
+  private static final TestDatabaseName MYSQL_TEST_DATABASE = 
TestDatabaseName.MYSQL_JDBC_BACKEND;
+  private static final TestDatabaseName POSTGRESQL_TEST_DATABASE = 
TestDatabaseName.PG_JDBC_BACKEND;
+
+  private static final String ACCEPT = "application/vnd.gravitino.v1+json";
+  private static final String IDP_REST_EXTENSION_PACKAGE =
+      "org.apache.gravitino.idp.web.rest.feature";
+  private static final String BASIC_AUTHENTICATOR_CLASS =
+      "org.apache.gravitino.idp.auth.BasicAuthenticator";
+  private static final String INITIAL_ADMIN_PASSWORD_ENV = 
"GRAVITINO_INITIAL_ADMIN_PASSWORD";
+  private static final String ADMIN = "admin";
+  private static final String ADMIN_PASSWORD = "Passw0rd-For-Admin1";
+  private static final String USER1 = "user1";
+  private static final String USER2 = "user2";
+  private static final String GROUP1 = "group1";
+  private static final String USER_PASSWORD = "Passw0rd-For-User1";
+  private static final String UPDATED_PASSWORD = "Passw0rd-For-User2";
+
+  private static final HttpClient HTTP = HttpClient.newHttpClient();
+
+  private Path h2Path;
+
+  static Stream<String> jdbcBackends() {
+    return Stream.of(H2_BACKEND, MYSQL_BACKEND, POSTGRESQL_BACKEND);
+  }
+
+  @ParameterizedTest
+  @MethodSource("jdbcBackends")
+  public void testIdpRestApis(String backendType) throws Exception {
+    setEnv(INITIAL_ADMIN_PASSWORD_ENV, ADMIN_PASSWORD);
+    Config relationalConfig = createRelationalBackendConfig(backendType);
+    int httpPort = RESTUtils.findAvailablePort(5000, 6000);
+    ServerConfig serverConfig = newServerConfig(httpPort, relationalConfig);
+
+    GravitinoServer gravitinoServer = new GravitinoServer(serverConfig, 
GravitinoEnv.getInstance());
+    IdpUserGroupManager idpUserGroupManager = null;
+    try {
+      gravitinoServer.initialize();
+      gravitinoServer.start();
+      String apiBase = String.format("http://localhost:%d/api";, httpPort);
+      idpUserGroupManager =
+          IdpUserGroupManager.getInstance(serverConfig, 
GravitinoEnv.getInstance().idGenerator());
+
+      assertEquals(200, get(apiBase, "/version", ADMIN, 
ADMIN_PASSWORD).statusCode());
+      assertEquals(401, get(apiBase, "/idp/users/" + USER1, null, 
null).statusCode());
+
+      postUser(apiBase, USER2, USER_PASSWORD);
+      assertEquals(403, get(apiBase, "/idp/users/" + USER2, USER2, 
USER_PASSWORD).statusCode());
+      deleteUser(apiBase, USER2);
+
+      postUser(apiBase, USER1, USER_PASSWORD);
+      IdpUserResponse user = getUser(apiBase, USER1);
+      assertEquals(USER1, user.getUser().name());
+      assertTrue(user.getUser().groups().isEmpty());
+
+      changePassword(apiBase, USER1, UPDATED_PASSWORD);
+      assertEquals(USER1, getUser(apiBase, USER1).getUser().name());
+
+      assertTrue(deleteUser(apiBase, USER1));
+      assertEquals(
+          ErrorConstants.NOT_FOUND_CODE,
+          errorCode(get(apiBase, "/idp/users/" + USER1, ADMIN, 
ADMIN_PASSWORD)));
+
+      postUser(apiBase, USER1, USER_PASSWORD);
+      postUser(apiBase, USER2, USER_PASSWORD);
+
+      IdpGroupResponse group = postGroup(apiBase, GROUP1);
+      assertEquals(GROUP1, group.getGroup().name());
+      assertTrue(group.getGroup().users().isEmpty());
+
+      group =
+          putMembership(
+              apiBase, GROUP1, new GroupMembershipChangeRequest(new String[] 
{USER1, USER2}, null));
+      assertEquals(List.of(USER1, USER2), group.getGroup().users());
+
+      group =
+          putMembership(
+              apiBase, GROUP1, new GroupMembershipChangeRequest(null, new 
String[] {USER1, USER2}));
+      assertTrue(group.getGroup().users().isEmpty());
+
+      assertTrue(deleteGroup(apiBase, GROUP1, false));
+
+      deleteUser(apiBase, USER1);
+      deleteUser(apiBase, USER2);
+    } finally {
+      if (gravitinoServer != null) {
+        gravitinoServer.stop();
+      }
+      if (idpUserGroupManager != null) {
+        idpUserGroupManager.close();

Review Comment:
   Got This method has been rewritten.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to