mchades commented on code in PR #11226:
URL: https://github.com/apache/gravitino/pull/11226#discussion_r3315080993
##########
plugins/idp-basic/src/main/java/org/apache/gravitino/idp/storage/mapper/provider/h2/IdpGroupMetaH2Provider.java:
##########
@@ -19,11 +19,38 @@
package org.apache.gravitino.idp.storage.mapper.provider.h2;
+import org.apache.gravitino.idp.storage.mapper.IdpGroupMetaMapper;
+import org.apache.gravitino.idp.storage.mapper.IdpUserGroupRelMapper;
+import org.apache.gravitino.idp.storage.mapper.IdpUserMetaMapper;
import
org.apache.gravitino.idp.storage.mapper.provider.base.IdpGroupMetaBaseSQLProvider;
+import org.apache.ibatis.annotations.Param;
/** SQL provider for IdP group metadata statements on H2 backends. */
public class IdpGroupMetaH2Provider extends IdpGroupMetaBaseSQLProvider {
+ @Override
+ public String selectIdpGroupWithUsers(@Param("groupName") String groupName) {
+ return "SELECT g.group_name as name,"
+ + " '['"
+ + " || COALESCE(GROUP_CONCAT("
+ + " CASE"
+ + " WHEN u.user_name IS NOT NULL AND u.user_name <> ''"
+ + " THEN '\"' || u.user_name || '\"'"
+ + " ELSE NULL"
+ + " END), '')"
+ + " || ']' as usernames"
Review Comment:
Should this logic be handled within the Mapper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
