mchades commented on code in PR #11226:
URL: https://github.com/apache/gravitino/pull/11226#discussion_r3315060254
##########
plugins/idp-basic/src/main/java/org/apache/gravitino/idp/model/IdpUser.java:
##########
@@ -26,16 +26,19 @@
public class IdpUser {
private final String name;
+ private final String passwordHash;
private final List<String> groupNames;
/**
* Creates a built-in IdP user.
*
* @param name The username.
+ * @param passwordHash The password hash, or null when not loaded or not
applicable.
* @param groupNames The group names the user belongs to.
*/
- public IdpUser(String name, List<String> groupNames) {
+ public IdpUser(String name, String passwordHash, List<String> groupNames) {
Review Comment:
Should you check the parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
