laserninja commented on code in PR #10671:
URL: https://github.com/apache/gravitino/pull/10671#discussion_r3321858126
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -123,7 +123,9 @@ public IcebergTableOperations(
public Response listTable(
@AuthorizationMetadata(type = Entity.EntityType.CATALOG)
@PathParam("prefix") String prefix,
@AuthorizationMetadata(type = EntityType.SCHEMA) @Encoded()
@PathParam("namespace")
- String namespace) {
+ String namespace,
+ @QueryParam("pageToken") String pageToken,
Review Comment:
This follows the Iceberg REST spec, pageToken is defined as an opaque string
(it's a cursor, not necessarily numeric), while pageSize is a numeric integer
representing the max items per page. With the switch to cursor-based tokens,
the distinction is even more relevant: tokens are now the name of the last item
on the page (e.g. "db.my_table"), not a numeric offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
