laserninja commented on PR #10671: URL: https://github.com/apache/gravitino/pull/10671#issuecomment-4570167964
Great suggestion. Implemented exactly as you described. Items are now sorted deterministically by name, the page token is the name of the last item on the current page, and the next request returns items strictly after the cursor by string comparison. The known limitations (items created after cursor but before last item are missed, same as standard keyset pagination) are documented in the IcebergPaginationHelper Javadoc. Also added comprehensive unit tests for the cursor-based logic in a new TestIcebergPaginationHelper class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
