lasdf1234 commented on code in PR #11457:
URL: https://github.com/apache/gravitino/pull/11457#discussion_r3369479812
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -244,6 +247,37 @@ private static boolean checkEqual(
&&
gravitinoCatalogManager.gravitinoClientConfig.equals(gravitinoClientConfig);
}
+ private static GravitinoAdminClient buildBasicClient(
+ String gravitinoUri, Map<String, String> config) {
+ String username =
config.get(GravitinoCatalogStoreFactoryOptions.BASIC_USERNAME);
+ String password =
config.get(GravitinoCatalogStoreFactoryOptions.BASIC_PASSWORD);
+ if (Strings.isNullOrEmpty(username)) {
Review Comment:
Got resolved.
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -244,6 +247,37 @@ private static boolean checkEqual(
&&
gravitinoCatalogManager.gravitinoClientConfig.equals(gravitinoClientConfig);
}
+ private static GravitinoAdminClient buildBasicClient(
+ String gravitinoUri, Map<String, String> config) {
+ String username =
config.get(GravitinoCatalogStoreFactoryOptions.BASIC_USERNAME);
+ String password =
config.get(GravitinoCatalogStoreFactoryOptions.BASIC_PASSWORD);
+ if (Strings.isNullOrEmpty(username)) {
+ throw new IllegalArgumentException(
Review Comment:
Got resolved.
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/security/GravitinoAuthProvider.java:
##########
@@ -230,6 +245,21 @@ private static void buildSimpleAuth(
}
}
+ private static void buildBasicAuth(
+ GravitinoAdminClient.AdminClientBuilder builder, Map<String, String>
config) {
+ String username = config.get(BASIC_USERNAME_KEY);
+ String password = config.get(BASIC_PASSWORD_KEY);
+ if (StringUtils.isBlank(username)) {
Review Comment:
Got resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
