diqiu50 commented on code in PR #11457: URL: https://github.com/apache/gravitino/pull/11457#discussion_r3377401360
########## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoBasicAuthIT.java: ########## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.trino.connector.integration.test; + +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.Maps; +import java.io.IOException; +import java.net.HttpURLConnection; +import java.net.URL; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Map; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import org.apache.commons.io.FileUtils; +import org.apache.gravitino.Configs; +import org.apache.gravitino.client.GravitinoAdminClient; +import org.apache.gravitino.integration.test.util.BaseIT; +import org.awaitility.Awaitility; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testcontainers.containers.BindMode; +import org.testcontainers.containers.GenericContainer; + +/** + * End-to-end integration test for Trino connector Basic authentication against the built-in IdP. + * Exercises the full path: Trino connector plugin → HTTP Basic credentials → Gravitino REST → + * built-in IdP validation. + */ +@Tag("gravitino-docker-test") +public class TrinoBasicAuthIT { + + private static final Logger LOG = LoggerFactory.getLogger(TrinoBasicAuthIT.class); + + private static final String METALAKE = "trino_basic_auth"; + private static final String ADMIN = "admin"; + private static final String ADMIN_PASSWORD = "Passw0rd-For-Admin1"; + private static final String IDP_REST_EXTENSION_PACKAGE = + "org.apache.gravitino.idp.web.rest.feature"; + private static final int TRINO_PORT = 8080; + + private static BaseIT baseIT; + private static GenericContainer<?> trinoContainer; + private static Path trinoConfigDir; + private static TrinoQueryRunner trinoQueryRunner; + + @BeforeAll + static void setUp() throws Exception { + baseIT = new BaseIT(); + BaseIT.setEnv("GRAVITINO_INITIAL_ADMIN_PASSWORD", ADMIN_PASSWORD); + baseIT.registerCustomConfigs(idpConfigs()); + baseIT.startIntegrationTest(); + + String gravitinoUri = String.format("http://127.0.0.1:%d";, baseIT.getGravitinoServerPort()); + try (GravitinoAdminClient adminClient = + GravitinoAdminClient.builder(gravitinoUri).withBasicAuth(ADMIN, ADMIN_PASSWORD).build()) { + adminClient.createMetalake(METALAKE, "Trino basic auth test metalake", Maps.newHashMap()); + } + + trinoConfigDir = + prepareTrinoConfigDir(baseIT.getGravitinoServerPort(), METALAKE, ADMIN, ADMIN_PASSWORD); + trinoContainer = startTrinoContainer(trinoConfigDir, trinoConnectorDir()); + trinoQueryRunner = + new TrinoQueryRunner( + String.format("http://127.0.0.1:%d";, trinoContainer.getMappedPort(TRINO_PORT))); + } + + @AfterAll + static void tearDown() throws IOException, InterruptedException { + if (trinoQueryRunner != null) { + trinoQueryRunner.stop(); + } + if (trinoContainer != null) { + trinoContainer.stop(); + } + if (trinoConfigDir != null) { + try { + FileUtils.deleteDirectory(trinoConfigDir.toFile()); + } catch (IOException e) { + LOG.warn("Failed to delete temporary Trino config directory {}", trinoConfigDir, e); + } + } + if (baseIT != null) { + baseIT.stopIntegrationTest(); + } + } + + @Test + void testTrinoConnectorConnectsWithBasicAuth() { + Assertions.assertDoesNotThrow(() -> trinoQueryRunner.runQuery("SHOW CATALOGS")); Review Comment: Your test only relies on SHOW CATALOGS, which is insufficient to validate your changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
