lasdf1234 commented on code in PR #11457: URL: https://github.com/apache/gravitino/pull/11457#discussion_r3371744971
########## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoBasicAuthIT.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.trino.connector.integration.test; + +import com.google.common.collect.Maps; +import java.io.IOException; +import java.util.Map; +import org.apache.gravitino.Configs; +import org.apache.gravitino.client.GravitinoAdminClient; +import org.apache.gravitino.client.GravitinoMetalake; +import org.apache.gravitino.integration.test.util.BaseIT; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + +/** + * End-to-end integration test for Trino connector Basic authentication against the built-in IdP. + * Verifies HTTP Basic credentials against Gravitino REST with the built-in IdP. Trino catalog + * properties {@code gravitino.client.authType=basic}, {@code gravitino.client.basic.username}, and + * {@code gravitino.client.basic.password} are mapped to {@link + * GravitinoAdminClient.AdminClientBuilder#withBasicAuth(String, String)} by the connector; + * connector-side config parsing is covered by {@code TestGravitinoAuthProvider#testBuildBasicAuth}. + */ +public class TrinoBasicAuthIT extends BaseIT { + Review Comment: Thank you very much for your suggestion.I have restructured this method and it will conduct the basic authentication test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
