roryqi commented on PR #12132: URL: https://github.com/apache/gravitino/pull/12132#issuecomment-5076896393
> @jerryshao @roryqi @lasdf1234 — this review round is complete. > > Changes made from the feedback: > > * separated the public `KmsReference` / `KmsApi` values from the developer-facing SPI, DTOs, and exceptions in `common`; > * restored the string-backed `KmsApi` enum so supported APIs are validated at the boundary while implementations remain SPI-extensible; > * modeled authoritative key-not-found with `Optional.empty()` and clarified key-state and client preconditions; > * normalized logical source names while preserving provider-native key IDs; > * added DTO serialization, provider-contract, and fake-client coverage; and > * removed the unnecessary test-fixture utility dependency and filed [[Improvement] Audit and narrow Jackson dependency boundaries in api and common #12193](https://github.com/apache/gravitino/issues/12193) for the broader Jackson dependency audit. > > Focused API/common tests, Spotless, fixture packaging, and Javadocs pass. Current CI has no failures, with the remaining jobs still running. All review threads are resolved. > > @roryqi @lasdf1234, please re-review when ready. If you use enum for KmsApi and add a new KmsApi, you must modify the code. right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
