roryqi commented on PR #12132: URL: https://github.com/apache/gravitino/pull/12132#issuecomment-5077132520
> Yes — adding a new `KmsApi` requires a core API change, and that’s intentional. `KmsApi` is the closed set of APIs Gravitino supports (same idea as `JobType`). The SPI remains the extension point for implementations of those APIs. > > I’m keeping the enum for this PR. Further debate on open strings vs enum isn’t material to the rest of the series, so I’d rather not bikeshed it here. > > Ref: Effective Java (3rd ed.), Item 34 — prefer enums over string constants for a fixed set of values known at compile time. > > LLMs make code modifications inexpensive these days. I'd like to focus on getting the well tested, well designed, well specified, well functioning code possible. "Insist on highest standards" > > @roryqi @jerryshao WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
