nevzheng commented on code in PR #12132: URL: https://github.com/apache/gravitino/pull/12132#discussion_r3651608140
########## api/src/main/java/org/apache/gravitino/encryption/kms/KmsApi.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.encryption.kms; + +import java.util.Arrays; +import java.util.Locale; +import java.util.stream.Collectors; +import org.apache.gravitino.annotation.DeveloperApi; + +/** The KMS product API that defines key identifier and operation semantics. */ +@DeveloperApi +public enum KmsApi { Review Comment: @roryqi Thanks for the sync — we agreed to prefer a `String` for the KMS API identifier so the contract stays easier to extend. Changes in the follow-up: - Removed the closed `KmsApi` enum - Restored string-backed `KmsReference.api` / `KmsClientFactory.api` with exact matching (no trim/lowercase normalization) - Documented and enforced lowercase kebab-case identifiers with no padding via `KmsApiIdentifiers` - Shared that validation between `KmsReference` and `FakeKmsClient` - Added `TestKmsReferenceDTO` coverage, including custom identifiers like `acme-kms-v2` - Kept `source` trimming and left `keyId` untouched Dispatch remains SPI-based. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
