nevzheng commented on code in PR #12133:
URL: https://github.com/apache/gravitino/pull/12133#discussion_r3652594644
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -635,10 +650,26 @@ public void shutdown() {
}
}
+ closeKmsClientRegistry();
+
LOG.info("Gravitino Environment is shut down.");
}
+ private void closeKmsClientRegistry() {
+ KmsClientRegistry registry = kmsClientRegistry;
Review Comment:
note: I removed this one-use helper and inlined the registry close into
`shutdown()`. I also removed the duplicate `null` lifecycle state;
`KmsClientRegistry` now owns its closed state.
question: Could you expand on which convention you mean? I’m not sure
whether the concern was the one-use helper or something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
