lasdf1234 commented on code in PR #12133:
URL: https://github.com/apache/gravitino/pull/12133#discussion_r3652697694
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -635,10 +650,26 @@ public void shutdown() {
}
}
+ closeKmsClientRegistry();
+
LOG.info("Gravitino Environment is shut down.");
}
+ private void closeKmsClientRegistry() {
+ KmsClientRegistry registry = kmsClientRegistry;
Review Comment:
Since this method is only used once—and the other methods in the class
follow the same pattern—it can be inlined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
