nevzheng commented on code in PR #12133:
URL: https://github.com/apache/gravitino/pull/12133#discussion_r3652594644
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -635,10 +650,26 @@ public void shutdown() {
}
}
+ closeKmsClientRegistry();
+
LOG.info("Gravitino Environment is shut down.");
}
+ private void closeKmsClientRegistry() {
+ KmsClientRegistry registry = kmsClientRegistry;
Review Comment:
note: I removed the single-use helper and inlined registry shutdown into
`GravitinoEnv.shutdown()`. `KmsClientRegistry` now owns its closed state, so
`GravitinoEnv` no longer duplicates that lifecycle state.
question: Could you clarify which code convention you mean? I am not sure
whether your concern was the single-use helper, the field lifecycle, or
something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
