nevzheng commented on code in PR #12215: URL: https://github.com/apache/gravitino/pull/12215#discussion_r3658850672
########## common/src/main/java/org/apache/gravitino/secret/memory/InMemorySecretsProvider.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.secret.memory; + +import java.nio.charset.StandardCharsets; +import java.util.Base64; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.gravitino.secret.GravitinoSecretProvider; +import org.apache.gravitino.secret.SecretUrn; +import org.apache.gravitino.secret.SecretWriteContext; + +/** + * In-memory secret provider for development and unit tests. + * + * <p>Secrets are stored in process memory only and are lost on restart. Values are Base64-encoded + * for opaque storage, which is <strong>not</strong> encryption. Do not use this provider in + * production. + */ +public class InMemorySecretsProvider implements GravitinoSecretProvider { Review Comment: issue (blocking): close() does not release stored secrets. suggestion: Override close() and call secrets.clear(), and assert that in the unit test. As written, close() leaves secrets reachable for the process lifetime. ########## common/src/main/java/org/apache/gravitino/secret/GravitinoSecretProvider.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.secret; + +import java.util.Map; +import org.apache.gravitino.annotation.DeveloperApi; + +/** Service provider interface for Gravitino secret backends. */ +@DeveloperApi +public interface GravitinoSecretProvider { + + /** + * Initializes this provider after construction. + * + * <p>The default implementation is a no-op so providers that need no configuration (for example + * in-memory) can keep a no-arg constructor only. + * + * @param name the configured provider instance name + * @param config provider-specific configuration (without the {@code gravitino.secret.provider. + * <name>.} prefix) + */ + default void initialize(String name, Map<String, String> config) {} Review Comment: suggestion (blocking): Please remove the default no-op initialize/close. Each implementer should explicitly consider lifecycle (an empty body is fine). Silent defaults make it too easy to skip cleanup. ########## common/src/main/java/org/apache/gravitino/secret/memory/InMemorySecretsProvider.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.secret.memory; + +import java.nio.charset.StandardCharsets; +import java.util.Base64; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.gravitino.secret.GravitinoSecretProvider; +import org.apache.gravitino.secret.SecretUrn; +import org.apache.gravitino.secret.SecretWriteContext; + +/** + * In-memory secret provider for development and unit tests. + * + * <p>Secrets are stored in process memory only and are lost on restart. Values are Base64-encoded + * for opaque storage, which is <strong>not</strong> encryption. Do not use this provider in + * production. + */ +public class InMemorySecretsProvider implements GravitinoSecretProvider { Review Comment: note (non-blocking, security): Map.clear() only drops references. The JVM does not securely zero String/heap contents when values become unreachable, so secret material can linger until GC (and still isn’t guaranteed wiped). Fine for this test-only provider if documented; production backends should use wipeable byte[]/char[] with explicit zeroing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
