lasdf1234 commented on code in PR #12215: URL: https://github.com/apache/gravitino/pull/12215#discussion_r3661962720
########## common/src/main/java/org/apache/gravitino/secret/memory/InMemorySecretsProvider.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.secret.memory; + +import java.nio.charset.StandardCharsets; +import java.util.Base64; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.gravitino.secret.GravitinoSecretProvider; +import org.apache.gravitino.secret.SecretUrn; +import org.apache.gravitino.secret.SecretWriteContext; + +/** + * In-memory secret provider for development and unit tests. + * + * <p>Secrets are stored in process memory only and are lost on restart. Values are Base64-encoded + * for opaque storage, which is <strong>not</strong> encryption. Do not use this provider in + * production. + */ +public class InMemorySecretsProvider implements GravitinoSecretProvider { Review Comment: Agreed. Since this provider is intended for development and unit tests only, I kept String/Base64 storage and documented that close() clears map references but does not securely zero heap contents (String is not wipeable). Production providers should use wipeable byte[]/char[] and explicitly zero them on delete/close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
