roryqi commented on code in PR #12215: URL: https://github.com/apache/gravitino/pull/12215#discussion_r3695197930
########## common/src/main/java/org/apache/gravitino/secret/SecretWriteContext.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.secret; + +import java.util.Objects; +import org.apache.gravitino.annotation.DeveloperApi; + +/** Immutable context for writing a secret at entity create time. */ +@DeveloperApi +public final class SecretWriteContext { + + private final String providerName; + private final String entityType; + private final long entityId; + private final String propertyKey; + + /** + * Creates a secret write context. + * + * @param providerName the configured secret provider name used in the URN + * @param entityType the entity type (catalog, schema, or fileset) + * @param entityId the entity identifier + * @param propertyKey the property key holding the secret + */ + public SecretWriteContext( Review Comment: Entity is the core module concept. We shouldn't put it into the common module. Maybe you can use securable object type and objectUUID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
