Copilot commented on code in PR #12661:
URL: https://github.com/apache/gravitino/pull/12661#discussion_r3868272382
##########
mcp-server/build.gradle.kts:
##########
@@ -234,7 +247,7 @@ tasks {
doLast {
val isortExitCode = exec {
workingDir = pythonProjectDir
- commandLine(venvPython, "-m", "isort", "--check", "mcp_server",
"tests")
+ commandLine(venvExecutable("isort"), "--check", "mcp_server", "tests")
isIgnoreExitValue = false
}.exitValue
Review Comment:
`formatCheckPython` captures `exitValue` and then checks it, but
`isIgnoreExitValue = false` causes Gradle to throw on a non-zero exit before
the `exitValue`/custom `GradleException` logic can run. As written, the custom
failure message is effectively unreachable.
This issue also appears on line 258 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
