yuqi1129 commented on code in PR #12661:
URL: https://github.com/apache/gravitino/pull/12661#discussion_r3868408736


##########
mcp-server/build.gradle.kts:
##########
@@ -46,6 +46,19 @@ val venvPython = when {
     venvDir.resolve("bin/python").absolutePath
 }
 
+// The formatters are invoked through their console scripts rather than 
`python -m <tool>`:
+// isort 9 no longer ships an `__main__` module, so `python -m isort` cannot 
be executed.
+fun venvExecutable(name: String): String = when {

Review Comment:
   Done in 43f17ff7a0 — `venvExecutable` now sits above and `val venvPython = 
venvExecutable("python")`, so the OS check exists in one place. Resolves to the 
same paths as before (`Scripts/python.exe` / `bin/python`).
   
   `./gradlew :mcp-server:formatCheckPython` still passes, and the other tasks 
that use `venvPython` invoke the same interpreter path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to