yuqi1129 commented on code in PR #12661:
URL: https://github.com/apache/gravitino/pull/12661#discussion_r3868331762
##########
mcp-server/build.gradle.kts:
##########
@@ -234,7 +247,7 @@ tasks {
doLast {
val isortExitCode = exec {
workingDir = pythonProjectDir
- commandLine(venvPython, "-m", "isort", "--check", "mcp_server",
"tests")
+ commandLine(venvExecutable("isort"), "--check", "mcp_server", "tests")
isIgnoreExitValue = false
}.exitValue
Review Comment:
Good catch — fixed in 030d341240. Both `exec` blocks now set
`isIgnoreExitValue = true`, so the exit code reaches the check and the
tool-specific message is what gets reported.
Verified by deliberately breaking the import order in
`mcp-server/tests/__init__.py`:
```
* What went wrong:
Execution failed for task ':mcp-server:formatCheckPython'.
> Python isort formatting check failed
```
(previously this surfaced as a bare `ExecException`). The passing path is
unchanged: `./gradlew :mcp-server:formatCheckPython` → BUILD SUCCESSFUL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
