geyanggang commented on code in PR #13769:
URL: https://github.com/apache/gravitino/pull/13769#discussion_r4246638866


##########
catalogs/catalog-jdbc-mysql/src/test/java/org/apache/gravitino/catalog/mysql/integration/test/CatalogMysqlIT.java:
##########
@@ -2364,6 +2364,10 @@ void testAlterCatalogProperties() throws SQLException {
     String password = MYSQL_CONTAINER.getPassword();
     String wrongPassword = password + "wrong";
     catalogProperties.put(JdbcConfig.PASSWORD.getKey(), wrongPassword);
+    // This test deliberately creates the catalog with a wrong password and 
then fixes it via
+    // alterCatalog, so it must opt out of create-time backend verification; 
otherwise the create
+    // itself would be rejected for the unreachable backend (the behavior 
added in #2154).
+    catalogProperties.put(Catalog.PROPERTY_VERIFY_ON_CREATE, "false");

Review Comment:
   Fixed. testExistingCatalogConnectionWithUnreachableEndpoint now sets 
verify-on-create=false so it still reaches its existing-catalog assertion; 
default create-time rejection is covered separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to