geyanggang commented on code in PR #13769:
URL: https://github.com/apache/gravitino/pull/13769#discussion_r4247172874


##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -996,7 +996,11 @@ public void testConnection(
                       .build())
               .build();
 
-      CatalogWrapper wrapper = createCatalogWrapper(dummyEntity, mergedConfig);
+      // Pass null propsToValidate so wrapper construction does NOT run the 
create-time backend
+      // validation (BaseCatalog#validateOnCreate). This standalone path 
performs its own explicit
+      // probe below; letting the wrapper validate as well would probe the 
backend twice and could
+      // fail an otherwise-successful test on a transient second-round-trip 
error.
+      CatalogWrapper wrapper = createCatalogWrapper(dummyEntity, null);

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to