yuqi1129 commented on code in PR #13769:
URL: https://github.com/apache/gravitino/pull/13769#discussion_r4247374758
##########
api/src/main/java/org/apache/gravitino/Catalog.java:
##########
@@ -136,6 +136,16 @@ enum CloudName {
/** The property indicates the catalog is in use. */
String PROPERTY_IN_USE = "in-use";
+ /**
+ * The property that gates create-time backend verification for relational
JDBC catalogs. When it
+ * is {@code true} (the default, and when absent) such a catalog verifies
that its backend is
+ * reachable at create time; setting it to {@code false} registers the
catalog without that check,
+ * for a backend that is temporarily unavailable. It is a hidden,
non-reserved property, so a
+ * caller may set it on the create request, and it is persisted on the
catalog entity to record
+ * the choice. Non-JDBC catalogs ignore it.
+ */
+ String PROPERTY_VERIFY_ON_CREATE = "gravitino.catalog.verify-on-create";
Review Comment:
I noticed that properties like `in-use` and `package` do not start with
`gravitino.catalog`, do you have any consideration here?
##########
core/src/main/java/org/apache/gravitino/connector/BaseCatalogPropertiesMetadata.java:
##########
@@ -102,7 +103,15 @@ protected Map<String, PropertyEntry<?>>
specificPropertyEntries() {
PROPERTY_METALAKE_IN_USE,
"The property indicating the metalake that holds the catalog
is in use",
true /* default value */,
- true /* hidden */)),
+ true /* hidden */),
+ PropertyEntry.booleanPropertyEntry(
+ PROPERTY_VERIFY_ON_CREATE,
Review Comment:
So the property is only applicable to jdbc catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
