mchades commented on code in PR #13771:
URL: https://github.com/apache/gravitino/pull/13771#discussion_r4256522618
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogCapability.java:
##########
@@ -48,6 +60,21 @@ public CapabilityResult supportsHierarchicalSchema() {
return CapabilityResult.SUPPORTED;
}
+ @Override
+ public CapabilityResult caseSensitiveOnName(Scope scope) {
+ if (hiveBackend) {
+ switch (scope) {
+ case SCHEMA:
+ case TABLE:
Review Comment:
This upgrade case still applies in ca27d8c608: [schema/table
normalization](https://github.com/apache/gravitino/blob/ca27d8c608308c5c7a404fa71711aae88ebddcc6/catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogCapability.java#L65)
has been reintroduced. On PostgreSQL, a pre-upgrade `Orders` registration
remains stored as `Orders`, but every lookup now uses `orders`. The lookup
misses it, importing the same Hive object conflicts with its retained
`gravitino.identifier`, and the reload misses it again. Existing mixed-case
schemas have the same problem.
Please add a compatible lookup or migration that preserves existing entity
IDs and their governance relationships, plus an upgrade regression test seeded
with mixed-case schema/table registrations created under the old behavior. The
new mixed-case tests do not cover this pre-upgrade state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
