roryqi commented on code in PR #13771:
URL: https://github.com/apache/gravitino/pull/13771#discussion_r4257257387


##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalog.java:
##########
@@ -86,7 +86,10 @@ static boolean shouldValidateWarehouseProperty(String 
backend, String warehouse)
 
   @Override
   public Capability newCapability() {
-    return new 
IcebergCatalogCapability(HierarchicalSchemaUtil.schemaSeparator());
+    String backend = 
entity().getProperties().get(IcebergConstants.CATALOG_BACKEND);
+    return new IcebergCatalogCapability(
+        HierarchicalSchemaUtil.schemaSeparator(),
+        IcebergCatalogBackend.HIVE.name().equalsIgnoreCase(backend));

Review Comment:
   Follow-up: I simplified this further in b384b7f27b. The shared REPLACE 
COLUMNS test now uses the original table name and makes no case-sensitivity 
assumption. A dedicated direct-Hive test performs the 
lowercase-create/uppercase-access check. No test-only capability hook remains.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to