lasdf1234 commented on PR #13774: URL: https://github.com/apache/gravitino/pull/13774#issuecomment-6147791298
@roryqi Thanks for the thorough review. Status of the comments on this PR: | Topic | Status | | --- | --- | | LICENSE / NOTICE for new deps | Done — `db-scheduler`, shaded `cron-utils`, and `JSpecify` in `LICENSE.bin` | | OccupancyClaim fence (`id` + `createdAt`) | Done | | MySQL `DATETIME(6)` scheduler columns | Done | | PG `TIMESTAMP WITH TIME ZONE` scheduler columns | Done | | Config camelCase keys | Done — `expandThreads` / `cronThreads` / `commitThreads` | | Config `checkValue` (> 0) | Done | | Design §5.2 three physical `scheduled_*` tables | Done | | DB clock for claim lease (`DatabaseTimeSQL`) | Done | | bind-after-`runJob` cannot prevent duplicate submit | Acknowledged — documented submit contract; OccupancyGate follow-up must make `runJob` idempotent on `claim.id()` (no submit path in this PR) | | `UNIQUE(table_id, policy_id, finished_at)` / same-ms history | **Not changing in this PR** — keeping the soft-slot unique (same idiom as `deleted_at`); see reply on that thread for rationale | Happy to continue on the soft-slot uniqueness in a follow-up if we hit real collisions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
