lasdf1234 commented on code in PR #13774:
URL: https://github.com/apache/gravitino/pull/13774#discussion_r4266670306


##########
LICENSE.bin:
##########
@@ -411,6 +411,8 @@
    Fabric8 Kubernetes Client
    Fabric8 Kubernetes Model
    Fabric8 zjsonpatch
+   db-scheduler

Review Comment:
   No — NOTICE.bin does not need an update here.
   
   `db-scheduler`, the shaded `cron-utils` inside it, and `JSpecify` do not 
ship a NOTICE file (no META-INF/NOTICE in the jars, and no upstream NOTICE to 
aggregate). Per ASF practice we only add NOTICE content that a dependency 
provides; LICENSE.bin already lists these Apache-2.0 components.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to