lasdf1234 commented on code in PR #13801:
URL: https://github.com/apache/gravitino/pull/13801#discussion_r4271013073
##########
common/src/main/java/org/apache/gravitino/dto/policy/PolicyContentDTO.java:
##########
@@ -203,6 +224,29 @@ public Map<String, String> rewriteOptions() {
: Collections.unmodifiableMap(new LinkedHashMap<>(rewriteOptions));
}
+ @Nullable
+ public String timeTrigger() {
+ return timeTrigger;
+ }
+
+ @Nullable
+ public Boolean commitTrigger() {
+ return commitTrigger;
+ }
+
+ @Nullable
+ public Long minIntervalMs() {
+ return minIntervalMs;
+ }
+
+ public Map<String, String> jobOptions() {
+ return jobOptions == null ? Collections.emptyMap() : jobOptions;
Review Comment:
Agreed — all four Iceberg execution DTOs now return
`PolicyExecutionFields.copyOptions(...)` for `jobOptions()` / `updateOptions()`
(unmodifiable defensive copies, same idea as `rewriteOptions()`). Added a
regression test that mutating the returned maps throws.
##########
common/src/main/java/org/apache/gravitino/dto/policy/PolicyContentDTO.java:
##########
@@ -203,6 +224,29 @@ public Map<String, String> rewriteOptions() {
: Collections.unmodifiableMap(new LinkedHashMap<>(rewriteOptions));
}
+ @Nullable
+ public String timeTrigger() {
Review Comment:
Agreed — centralized docs on `PolicyContentDTO.ExecutionPeersDTO`
(null/empty semantics for the five peers). The four Iceberg DTOs implement that
interface so the public accessors share one Javadoc contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
