lasdf1234 commented on code in PR #13801: URL: https://github.com/apache/gravitino/pull/13801#discussion_r4282241037
########## api/src/main/java/org/apache/gravitino/policy/AbstractExecutablePolicyContent.java: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import java.util.Map; +import java.util.Objects; +import javax.annotation.Nullable; + +/** + * Base for built-in Iceberg maintenance policy contents that carry optional execution peers. + * + * <p>Peers are supplied at construction as an immutable {@link PolicyExecutionSpec}. Subclasses + * keep strategy fields separate and pass the spec through {@link + * #AbstractExecutablePolicyContent(PolicyExecutionSpec)}. Persisted JSON keeps peer keys flat by + * storing the scalar/map fields directly on this type (same layout as {@code PolicyContentDTO}); + * {@link #executionSpec()} reconstructs the in-memory composition. DTOs use the same flat keys via + * {@code DTOConverters}. + */ +public abstract class AbstractExecutablePolicyContent implements ExecutablePolicyContent { + + // Flat peer fields for persistence JSON (POConverters / anyFieldMapper). Kept in sync with + // PolicyExecutionSpec; do not nest under an "executionSpec" object. + @Nullable private final String timeTrigger; + @Nullable private final Boolean commitTrigger; + @Nullable private final Long minIntervalMs; + private final Map<String, String> jobOptions; + private final Map<String, String> updateOptions; Review Comment: Renamed to \`updaterOptions\` (JSON key + API) to align with runtime \`updater_options\` / \`updaterOptions()\`. Design doc updated in the same commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
