roryqi commented on code in PR #13801: URL: https://github.com/apache/gravitino/pull/13801#discussion_r4280638758
########## api/src/main/java/org/apache/gravitino/policy/AbstractExecutablePolicyContent.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import com.fasterxml.jackson.annotation.JsonUnwrapped; +import java.util.Objects; +import javax.annotation.Nullable; + +/** + * Base for built-in Iceberg maintenance policy contents that carry optional execution peers. + * + * <p>Peers are supplied at construction as an immutable {@link PolicyExecutionSpec}. Subclasses + * keep strategy fields separate and pass the spec through {@link + * #AbstractExecutablePolicyContent(PolicyExecutionSpec)}. Persisted JSON keeps peer keys flat via + * {@link JsonUnwrapped}. + */ +public abstract class AbstractExecutablePolicyContent implements ExecutablePolicyContent { + + @JsonUnwrapped private final PolicyExecutionSpec executionSpec; Review Comment: Please do not introduce `@JsonUnwrapped` here. Gravitino currently has no precedent for this annotation, and it couples the public API domain model to a specific persistence JSON layout. Please follow the existing DTO/converter pattern: keep `PolicyExecutionSpec` Jackson-independent, flatten the execution fields explicitly in `PolicyContentDTO` or the persistence representation, and reconstruct the spec in `DTOConverters` or `POConverters`. The new Jackson dependency in the `api` module should then be removed as well. ########## common/src/main/java/org/apache/gravitino/dto/policy/PolicyContentDTO.java: ########## @@ -85,10 +134,10 @@ public Map<String, String> properties() { /** Represents a typed iceberg compaction policy content DTO. */ @EqualsAndHashCode - @ToString + @ToString(exclude = {"jobOptions", "updateOptions"}) Review Comment: The redaction is incomplete: `rewriteOptions` is still rendered by both this Lombok-generated `toString()` and `IcebergDataCompactionContent.toString()`. Sensitive-key rejection is explicitly deferred, and the design now includes `rewriteOptions` among the bags that must reject credential-shaped keys, so an accidentally supplied credential can still be exposed in logs. Please exclude or redact `rewriteOptions` as well (keys/count only, no values). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
