nicknezis commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-929833982


   I'm slowly finding time to test. So far here are a couple of minor tweaks we 
will need to make:
   1. Add configmaps k8s role permissions
   ```
   rules:
   - apiGroups: 
     - ""
     resources: 
     - configmaps
     verbs: 
     - get
     - watch
     - list
   ```
   2. The `listConfigMaps` call is looking in the default namespace, but it 
should be using `getNamespace()` instead for that value.
   
   I'm making the edits and testing locally. Will report back with any other 
findings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to