surahman edited a comment on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-933896528


   I suspect it might be the API version. It should be:
   ```yaml
   apiVersion: v1
   ```
   and not:
   
   ```yaml
   apiVersion: apps/v1
   ```
   
   **_Edit:_**
   
   Verifying the Pod Template using the `metadata`, `annotations`, and `labels` 
will be misleading:
   
https://github.com/apache/incubator-heron/blob/2190502da0ad723db86a13216f5d9acd0b4c6474/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java#L388-L394
   
   I also find [kubeval](https://kubeval.instrumenta.dev/) helpful.
   
   There are some code modifications that will be coming in soon. I need to 
perform the check for the Pod Template earlier in `submit` rather than in 
`createStatefulSet`. This is to avoid orphaned/failed topologies from 
persisting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to