surahman commented on pull request #3710: URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-934004555
Thank you for testing things out. I have reverted the changes I made to where the checks for a valid Pod Template occur as it was not resolving the issue. An issue arises when attempting to submit a topology with a bad ConfigMap/Pod Template where the topology persists but pods are not created. For some reason this does not do what it is supposed to: https://github.com/apache/incubator-heron/blob/2190502da0ad723db86a13216f5d9acd0b4c6474/heron/scheduler-core/src/java/org/apache/heron/scheduler/LaunchRunner.java#L172-L178 If there is an issue with persisted state in the submitted Pods to K8s it might be an issue further downstream. The test suite validates that `loadPodFromTemplate` is creating the `V1PodTemplateSpec` from input. It would be great to have a second set of eyes on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
