surahman commented on a change in pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r818006804
########## File path: heron/tools/tracker/src/python/routers/metrics.py ########## @@ -119,7 +119,7 @@ async def get_metrics( # pylint: disable=too-many-arguments ) [email protected]("/metricstimeline", response_model=metricstimeline.MetricsTimeline) [email protected]("/metrics/timeline", response_model=metricstimeline.MetricsTimeline) Review comment: It appears as though the tests may need to be updated to reflect the changes in the URL path. ```bash '__integration_test_aggregator_bolt' metrics: container id -------------- [2022-03-02 07:57:58 +0000] [DEBUG]: HTTP Request: POST http://travis-job-8cdf8c58-8014-4613-82f9-8200967005f4:33905/stats "HTTP/1.1 200 " [2022-03-02 07:57:58 +0000] [WARNING]: Recieved response from Tmanager: Metrics not available for component `identity-bolt` INFO: 127.0.0.1:58232 - "GET /topologies/metrics?cluster=local&environ=default&topology=IntegrationTest_LocalReadWriteTopology&role=travis&component=identity-bolt&metricname=__complete-latency&metricname=__execute-latency&metricname=__process-latency&metricname=__jvm-uptime-secs&metricname=__jvm-process-cpu-load&metricname=__jvm-memory-used-mb&metricname=__emit-count%2Fdefault&metricname=__execute-count%2Fdefault&metricname=__ack-count%2Fdefault&metricname=__fail-count%2Fdefault&interval=-1 HTTP/1.1" 200 OK ``` ########## File path: heron/tools/tracker/src/python/routers/metrics.py ########## @@ -158,7 +158,7 @@ class MetricsQueryResponse(BaseModel): # pylint: disable=too-few-public-methods ) [email protected]("/metricsquery", response_model=MetricsQueryResponse) [email protected]("/metrics/query", response_model=MetricsQueryResponse) Review comment: It appears as though the tests may need to be updated to reflect the changes in the URL path. ```bash '__integration_test_aggregator_bolt' metrics: container id -------------- [2022-03-02 07:57:58 +0000] [DEBUG]: HTTP Request: POST http://travis-job-8cdf8c58-8014-4613-82f9-8200967005f4:33905/stats "HTTP/1.1 200 " [2022-03-02 07:57:58 +0000] [WARNING]: Recieved response from Tmanager: Metrics not available for component `identity-bolt` INFO: 127.0.0.1:58232 - "GET /topologies/metrics?cluster=local&environ=default&topology=IntegrationTest_LocalReadWriteTopology&role=travis&component=identity-bolt&metricname=__complete-latency&metricname=__execute-latency&metricname=__process-latency&metricname=__jvm-uptime-secs&metricname=__jvm-process-cpu-load&metricname=__jvm-memory-used-mb&metricname=__emit-count%2Fdefault&metricname=__execute-count%2Fdefault&metricname=__ack-count%2Fdefault&metricname=__fail-count%2Fdefault&interval=-1 HTTP/1.1" 200 OK ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
