surahman commented on pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1059452493
I have always had issues bringing up the UI so I can only look at the code. > One example is `topology` vs `topology_name`. There is an alias [here](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/metrics.py#L106), but it didn't seem to work. The naming convention for topologies has changed on K8s and I am not sure if this would affect the UI. `Labels` have the topology's name and the `StatefulSet` name has either `-manager` or `-executors` appended to it. I am not sure how the tracker manages the scraping and collecting of stats. > Another issue I'm seeing is an exception on an API call because `role` isn't present. But it's listed as `Optional`. The parameter is treated differently between the two set of routes. [Example 1](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/container.py#L44) and [Example 2](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/topologies.py#L112). According to the [`Optional`](https://docs.python.org/3/library/typing.html#typing.Optional) docs, a value of `None` will be returned as required. How is a `role` value of `None` handled? Exception? What changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
