nicknezis commented on pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1059410300
I'm running into some other issues with parameter mismatch betwen `ui` and `tracker`. So I'm doing a bit of testing. One example is `topology` vs `topology_name`. There is an alias [here](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/metrics.py#L106), but it didn't seem to work. I was testing with a failed Tracker API call and got different response when using either `topology` or `topology_name`. Perhaps the `alias` isn't working? @Code0x58 might have some insight in helping answer that question. Another issue I'm seeing is an exception on an API call because `role` isn't present. But it's listed as `Optional`. The parameter is treated differently between the two set of routes. [Example 1](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/container.py#L44) and [Example 2](https://github.com/apache/incubator-heron/blob/2baa27cdf68e531ec5e560bc61d3f26484d1e2ca/heron/tools/tracker/src/python/routers/topologies.py#L112). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
