nicknezis commented on a change in pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r835706783
##########
File path: heron/tools/tracker/src/python/routers/metrics.py
##########
@@ -151,19 +152,19 @@ class TimelinePoint(BaseModel): # pylint:
disable=too-few-public-methods
class MetricsQueryResponse(BaseModel): # pylint: disable=too-few-public-methods
"""A metrics timeline over an interval."""
- start_time: int = Field(..., alias="starttime")
- end_time: int = Field(..., alias="endtime")
+ starttime: int = Field(..., alias="starttime")
+ endtime: int = Field(..., alias="endtime")
Review comment:
I honestly don't remember the specifics, but I think the changes I made
was due to an error I encountered. But it might have been self inflicted based
on the various changes. At the moment, I don't know the right answer, but I
agree with your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
