surahman commented on pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1079456640
I think we can safely remove the `ResponseEnvelope`. There may have been grander plans when it was for its use but they do not seem to have ever been implemented. https://github.com/apache/incubator-heron/blob/8841d1c4d6b3156a40ffed856fb32c1ceb682855/heron/tools/tracker/src/python/utils.py#L56-L63 It is just a data struct with references to it restricted to: https://github.com/apache/incubator-heron/blob/8841d1c4d6b3156a40ffed856fb32c1ceb682855/heron/tools/tracker/src/python/app.py https://github.com/apache/incubator-heron/blob/8841d1c4d6b3156a40ffed856fb32c1ceb682855/heron/tools/tracker/src/python/utils.py The values of importance are limited to the HTTP response codes, which are themselves restricted to `success` and `failure`. Nothing else in the data structure is ever used in a worthwhile way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
