nicknezis commented on pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1079236798
To give some context to one of the issues I ran into with this work. In the Heron Tracker, we are now using FastAPI. There is a limitation in the framework which does not allow for custom routers in a nested router. Some information can be found here: https://github.com/tiangolo/fastapi/issues/4110 So I think my options are as follows. 1. Remove the envelope which was part of each returned API call. Not sure if it's a great idea to have. We didn't really use the feature. We never set the timing info. We already have HTTP return codes for status. 2. Keep the envelope on API returns, but implement in each handler method. The custom API Router decoration doesn't seem to work. 3. I can technically hack it by making separate nested `App` instantiations, but this seems wrong. In the PR, I've gone back and forth between option 1 and 2 as I worked through various issues. I'm currently leaning towards option 1. This is reflected in the PR as it currently stands. But I can be convinced that it is better to go back to the original API responses with the envelope on each Heron Tracker API result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
